rkhachatryan commented on code in PR #28661:
URL: https://github.com/apache/flink/pull/28661#discussion_r3605821064
##########
flink-runtime/src/main/java/org/apache/flink/streaming/runtime/io/checkpointing/ChannelState.java:
##########
@@ -98,4 +111,26 @@ public ChannelState emptyState() {
sequenceNumberInAnnouncedChannels.clear();
return this;
}
+
+ /**
+ * Dispatches checkpoint start: inserts recovery-checkpoint barriers into
in-recovery channels
+ * through the trigger, then notifies every input. (FLINK-38544
transitional: the spilling
+ * backend adds a third step handing the trigger's snapshot reader to the
channel-state writer.)
+ */
+ public void onCheckpointStartedForAllInputs(CheckpointBarrier barrier)
+ throws CheckpointException, IOException {
+ long cpId = barrier.getId();
+ try {
+ recoveryCheckpointTrigger.snapshotAndInsertBarriers(cpId);
+
+ for (CheckpointableInput input : inputs) {
+ input.checkpointStarted(barrier);
+ }
+ } catch (Throwable t) {
+ if (t instanceof CheckpointException) {
+ throw (CheckpointException) t;
+ }
+ ExceptionUtils.rethrowIOException(t);
+ }
+ }
Review Comment:
Don't we need to call `channelStateWriter.addInputDataFromSpill` in this
method?
Like here:
https://github.com/apache/flink/pull/28554/changes#diff-8104c9791f592faf61f8613d92c48aefcb89dae2e6d89ad02dff96bc80b94c18R136
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
