weiqingy opened a new pull request, #28796:
URL: https://github.com/apache/flink/pull/28796

   > **Stacked on #28353** (PR-1a). Until #28353 merges, this PR's diff 
includes PR-1a's commits; I'll rebase onto `master` once it is merged, after 
which the diff narrows to just this change.
   
   Part of the FLIP-497 implementation stack under umbrella 
[FLINK-36953](https://issues.apache.org/jira/browse/FLINK-36953). Landing order:
   
   | Step | Sub-task | Scope |
   | --- | --- | --- |
   | PR-1a | [FLINK-40167](https://issues.apache.org/jira/browse/FLINK-40167) | 
EARLY_FIRE hint surface + option validation (#28353) |
   | **PR-1b (this PR)** | 
[FLINK-40168](https://issues.apache.org/jira/browse/FLINK-40168) | Thread the 
hint into the interval join (planner → ExecNode) |
   | PR-2 | [FLINK-40169](https://issues.apache.org/jira/browse/FLINK-40169) | 
`target` option |
   | PR-3 | [FLINK-40170](https://issues.apache.org/jira/browse/FLINK-40170) | 
Update-producing changelog mode + insert-only guard |
   | PR-4 | [FLINK-40171](https://issues.apache.org/jira/browse/FLINK-40171) | 
Runtime early-fire emit + retraction |
   | PR-5 | [FLINK-40172](https://issues.apache.org/jira/browse/FLINK-40172) | 
Processing-time early fire on an event-time join |
   | PR-6 | [FLINK-40173](https://issues.apache.org/jira/browse/FLINK-40173) | 
JSON serde + restore coverage |
   | PR-7 | [FLINK-40174](https://issues.apache.org/jira/browse/FLINK-40174) | 
User-facing documentation |
   
   ## What is the purpose of the change
   
   Threads the (already-registered) `EARLY_FIRE` hint through the planner to 
the ExecNode. `StreamPhysicalIntervalJoinRule` reads the hint, resolves the 
effective time mode from the join's time domain, validates the domain 
combinations, and threads the delay and time mode into `StreamExecIntervalJoin` 
as NON_NULL JSON fields. The operator receives the parameters but ignores them; 
runtime behavior lands in PR-4.
   
   ## Brief change log
   
     - `StreamPhysicalIntervalJoinRule` reads the hint, resolves the effective 
time mode, rejects row-time triggering on a processing-time join, and rejects 
(for now) processing-time triggering on an event-time join.
     - Thread `earlyFireDelay`/`earlyFireTimeMode` through 
`StreamPhysicalIntervalJoin` into `StreamExecIntervalJoin` as NON_NULL JSON 
fields.
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
     - `EarlyFireJoinHintTest`: `earlyFireDelay`/`earlyFireTimeMode` reach the 
exec plan; row-time-on-proctime and processing-time-on-rowtime are rejected.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no (adds NON_NULL JSON fields to the interval-join 
ExecNode)
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no (planner threading 
for the FLIP-497 hint)
     - If yes, how is the feature documented? not applicable
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code (Anthropic)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to