fhueske opened a new pull request, #28803:
URL: https://github.com/apache/flink/pull/28803

   ## What is the purpose of the change
   
   TimeIndicatorRelDataType.getOriginalType() does not reliably provide the 
correct nullability. The planner might have changed the nullability on the time 
indicator type without updating the nested original type. This change fixes the 
outputType computation to use the same rowtime type conversion as 
RelTimeIndicatorConverter.
   
   ## Brief change log
   
   * fix logic to convert a time indicator type into a regular timestamp 
preserving its actual nullability
   * conversion logic is derived from `RelTimeIndicatorConverter`
   
   ## Verifying this change
   
   * added unit tests to assert correct computation of lateral snapshot join 
output type
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? n/a
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [X] Yes (please specify the tool below)
   
   Generated-by: Claude Code 2.1.200 (Opus 4.8)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to