snuyanzin commented on code in PR #28808:
URL: https://github.com/apache/flink/pull/28808#discussion_r3632080642
##########
flink-core/src/test/java/org/apache/flink/types/variant/BinaryVariantInternalBuilderTest.java:
##########
@@ -120,6 +122,15 @@ void testParseJsonObject() throws IOException {
assertThat(variant.getField("k2").getDecimal()).isEqualTo(BigDecimal.valueOf(1.5));
}
+ @ParameterizedTest
+ @ValueSource(strings = {"NaN", "Infinity", "-Infinity", "1e400", "-1e400"})
+ void testParseJsonRejectsNonFiniteNumbers(final String nonFiniteNumber) {
+ // NaN and the infinities are not valid JSON; 1e400 is valid JSON but
overflows the double
Review Comment:
what about length of a number (not only for float/double)
in jackson it is configured with `StreamReadConstraints.DEFAULT_MAX_NUM_LEN`
which is by default 1000.
Means there might be issues with longer numbers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
