spuru9 commented on code in PR #28561:
URL: https://github.com/apache/flink/pull/28561#discussion_r3642982697
##########
flink-libraries/flink-state-processing-api/src/test/java/org/apache/flink/state/api/utils/SavepointTestBase.java:
##########
@@ -46,7 +49,14 @@
import static org.apache.flink.runtime.execution.ExecutionState.RUNNING;
/** A test base that includes utilities for taking a savepoint. */
-public abstract class SavepointTestBase extends AbstractTestBaseJUnit4 {
+public abstract class SavepointTestBase extends AbstractTestBase {
Review Comment:
We could either keep it public (it's extended cross-package by
SavepointReaderKeyedStateITCase/SavepointWindowReaderITCase in
`org.apache.flink.state.api`), or move SavepointTestBase into that same package
so it can drop to package-private — happy to do the move if you prefer that.
I would prefer keeping it as public as its in a util module which make
sense, but open to change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
