GitHub user weiqingy added a comment to the discussion: [Discussion] Agent 
observability: tracing & evaluation beyond metrics + event log

Thanks, this addresses all four, and the boundary you draw between lineage and 
#900 reads right to me.

On field placement, correcting one thing in my earlier comment: the state path 
does not preserve the causal edge on its own. `ActionStateUtil.generateKey` 
builds the key from the key, the sequence number, a hash of 
`event.getAttributes()`, and the Action, so the trigger Event's `id` never 
enters it. On a replay the trigger is a fresh occurrence with a new id, so the 
persisted children would still point at the original occurrence rather than the 
replayed one. That does not change where the fields belong, but it is the 
re-stamp on the reuse path that keeps the edge intact, not the placement itself.

Python identity and ordering are both settled from my side. Per-occurrence 
UUIDs close both halves of the identity question, and deferring sibling 
ordering to #900 sounds good.

I have put the rest of my comments on the PR (#923) so this does not fork into 
two threads.

GitHub link: 
https://github.com/apache/flink-agents/discussions/710#discussioncomment-17792089

----
This is an automatically sent email for [email protected].
To unsubscribe, please send an email to: [email protected]

Reply via email to