rmetzger commented on PR #28060: URL: https://github.com/apache/flink/pull/28060#issuecomment-5087750786
Thanks for reviewing this change @RocMarshal. @spuru9 has asked me to review this as well, but it didn't get to it yet, so thanks for taking a look and moving this forward. I am not sure if a full FLIP is needed. The change is only about 1100 lines big (size does not determine whether a FLIP is needed, a breaking API change can be a single line change, and still require a FLIP). I do agree that more feedback about this change would be good, because it is a very visible feature. I also have to admin that just from looking at the screenshots alone, I don't immediately understand if this visualized checkpoint info is correct or not. How about going with a middle ground and starting a discussion the dev@ mailing list, asking for additional feedback? If you still think a FLIP is needed, we should do it. I think you have more experience with the UI, you've looked closer at this PR than I and you are currently more active than I, so I am leaving the final decision to you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
