yuxiqian commented on PR #4482: URL: https://github.com/apache/flink-cdc/pull/4482#issuecomment-5090750411
> Thanks @lvyanquan and @yuxiqian for the feedback. > > I ran a JMH benchmark comparing the Supplier path against an equivalent if/else script and found no statistically significant difference — all configurations fall in the 330k-372k ops/ms range with overlapping confidence intervals, that means the JIT escape analysis reliably eliminates the anonymous `Supplier` allocation, so the per-record allocation concern is not a real bottleneck in practice. > > Given the lack of measurable benefit and the correctness risks @yuxiqian identified, I agree this change is not warranted. I'll go ahead and close this PR later. Thanks for the detailed benchmark report. > rvalue.toString() is for debugging purposes only and may not generate Java code with correct parentheses. > > For example, SQL statement (a - b) / (c + 1) will be converted to a - b / c + 1. Seems this is an existing bug, not introduced by changes in this PR. Could you please investigate this later? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
