Samrat002 commented on PR #28427:
URL: https://github.com/apache/flink/pull/28427#issuecomment-5099745166
Thanks @Izeren . I've decoupled this. DescriptiveStatisticsHistogram is now
reverted to its original commons-math3 implementation, so there's no
behavioural or backwards-compat change to the runtime histogram.
On reusing it from metrics-core, the blocker is that
DescriptiveStatisticsHistogramStatistics pulls in commons-math3 (Percentile,
StandardDeviation, …). Moving it to flink-metrics-core would force
commons-math3 onto the leanest, most widely-depended module (every
reporter/connector), which felt like a worse trade than a small dependency-free
histogram. And since the S3 plugin only depends on flink-runtime in test scope,
its main code can't reference DescriptiveStatisticsHistogram anyway.
`org.apache.flink.metrics` is parent-first for plugins and already on the
classpath, so SlidingWindowHistogram lives there for the plugin to use. If we
later want to unify the runtime histogram onto a shared sliding-window base,
I'd propose doing that as its own JIRA with proper percentile-compat testing
rather than as a side effect here. WDUT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
