gustavodemorais opened a new pull request, #28834:
URL: https://github.com/apache/flink/pull/28834

   ## What is the purpose of the change
   
   Using a non-orderable type (MAP, MULTISET, VARIANT, BITMAP, 
TIMESTAMP_WITH_TIME_ZONE) as a sort, grouping, or join key threw a raw 
UnsupportedOperationException from comparator code generation. This changes it 
to a ValidationException with a clearer, actionable message, since it is 
invalid user SQL rather than an internal error.
   
   ## Brief change log
   
   - Throw ValidationException instead of UnsupportedOperationException for 
non-orderable types in GenerateUtils.generateCompare, with a message that names 
the type and the remedy.
   - Update CalcITCase and BitmapSemanticTest to expect ValidationException and 
the new message.
   - Remove the now-unused UnsupportedOperationException allowance from 
FailingSqlTestStep.
   
   ## Verifying this change
   
   - CalcITCase
   - BitmapSemanticTest
   
   ## Does this pull request potentially affect one of the following parts:
   
   - Dependencies (does it add or upgrade a dependency): (no)
   - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (no)
   - The serializers: (no)
   - The runtime per-record code paths (performance sensitive): (no)
   - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
   - The S3 file system connector: (no)
   
   ## Documentation
   
   - Does this pull request introduce a new feature? (no)
   - If yes, how is the feature documented? (not applicable)
   
   ---
   
   ##### Was generative AI tooling used to co-author this PR?
   
   - [x] Yes (please specify the tool below)
   
   2.1.220 (Claude Code) with Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to