Github user twalthr commented on the issue:

    https://github.com/apache/flink/pull/3166
  
    I quickly went through the code. IMHO, we should limit the expressions 
given to the FilterableTableSource to a minimum. E.g. if you look at the 
[HCatInputFormat](https://hive.apache.org/javadocs/hcat-r0.5.0/inputoutput.html#Filter+Operators)
 they only support very basic operations `'and', 'or', 'like', '()', '=', '<>' 
(not equal), '<', '>', '<=' and '>='`. I think that is also enough for our use 
case. We should also only support basic datatypes. Then we add a Filter after 
the TableSource in case the TableSource does not support every predicate. What 
do you think @fhueske?
    
    The expression translation should also be more robust, just parsing the 
Calcite string is very error-prone, can you construct the Expression using the 
case-classes for that?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to