weiqingy commented on PR #930: URL: https://github.com/apache/flink-agents/pull/930#issuecomment-5140049908
@wenjin272 Following up on the ping above. A [Spec](https://github.com/apache/flink-agents/pull/930#issuecomment-5139830975) is now posted as a comment too. The [Implementation Description](https://github.com/apache/flink-agents/pull/930#issuecomment-5100699771) is as-built, written from the finished code. The Spec is what the change was meant to do, written before the code, and is much shorter. Could you please take a look at the PR and let me know which one is better from your review point of view? If you only have time to check one spot, please look at `toNativeResponseFormat` in `AzureOpenAIChatModelConnection.java`. It builds a throwaway params object to reach the SDK's schema builder, and has an `IllegalStateException` that no test exercises. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
