och5351 commented on PR #27971: URL: https://github.com/apache/flink/pull/27971#issuecomment-5140877451
Hi, @spuru9 ! Reviewed the code and verified the behavior manually. Started a local Flink cluster, loaded the dashboard, then stopped the cluster and waited for the polling failures to accumulate — the "Network Error" toast appeared as expected after the threshold was reached. No significant issues found in the code. The logic for tracking consecutive failures, showing the notification, and auto-dismissing on recovery looks correct. > start-cluster.sh <img width="1908" height="1002" alt="image" src="https://github.com/user-attachments/assets/e9f43909-a27d-4cb0-92f0-63bd6a5e647d"; /> > stop-cluster.sh <img width="1900" height="362" alt="image" src="https://github.com/user-attachments/assets/38b1aee1-9551-4709-b59c-0ebc53eddc82"; /> > start-cluster.sh <img width="1907" height="832" alt="image" src="https://github.com/user-attachments/assets/c63f164d-d655-4ab3-b4c3-1b07a72ecd7c"; /> LGTM cc. @RocMarshal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
