wenshao commented on code in PR #28850:
URL: https://github.com/apache/flink/pull/28850#discussion_r3694131286
##########
docs/data/sql_functions_zh.yml:
##########
@@ -1309,6 +1309,62 @@ json:
-- '[[1]]'
JSON_ARRAY(JSON_ARRAY(1))
```
+ - sql: JSON_TYPE(jsonValue)
+ table: jsonType(jsonValue)
+ description: |
+ Returns a string value indicating the type of jsonValue. Returns `NULL`
if jsonValue is
+ `NULL` or is not valid JSON.
Review Comment:
**[Suggestion]** The Chinese docs file (`sql_functions_zh.yml`) contains an
untranslated English description for JSON_TYPE, while all surrounding entries
are in Chinese. — Concrete cost: the adjacent `JSON_ARRAY` entry reads
"将数值列表构建为 JSON 数组字符串"; a Chinese-speaking user encounters a fully English
JSON_TYPE entry (56 lines of prose and SQL comments) copy-pasted from
`sql_functions.yml`, breaking the consistency of the localized documentation.
Translate the description block to Chinese, matching the style of
neighbouring entries (e.g., JSON_ARRAY, JSON_OBJECT). The SQL examples can
remain as-is; only the prose and SQL comments need translation.
_— qwen3.8-max-preview via Qwen Code /review_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
