charlesdong1991 opened a new pull request, #28875:
URL: https://github.com/apache/flink/pull/28875
## What is the purpose of the change
`OpenTelemetryMetricAdapter#convertHistogram` appended the histogram max
(quantile `1.0`) to the emitted summary twice, so every OpenTelemetry summary
data point contained a duplicated `quantile=1.0` entry. This fixes the
duplicate so each quantile is emitted exactly once.
## Brief change log
- Remove the duplicated `quantileList.add(... quantile 1.0 / max ...)` call
in
`OpenTelemetryMetricAdapter#convertHistogram`.
- Extend `OpenTelemetryMetricAdapterTest#testHistogram` to assert the summary
contains exactly `min + HISTOGRAM_QUANTILES + max` entries, has no
duplicate
quantiles, and emits the exact quantile sequence `[0, 0.5, 0.75, 0.95,
0.99, 1]`.
## Verifying this change
This change is covered by the existing (now strengthened)
`OpenTelemetryMetricAdapterTest#testHistogram`, which fails on the previous
code
(duplicate quantile 1.0) and passes with the fix.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: no
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
