dianfu commented on code in PR #28450:
URL: https://github.com/apache/flink/pull/28450#discussion_r3703806030
##########
flink-python/src/main/java/org/apache/flink/python/PythonOptions.java:
##########
@@ -156,7 +156,7 @@ public class PythonOptions {
public static final ConfigOption<String> PYTHON_EXECUTABLE =
ConfigOptions.key("python.executable")
.stringType()
- .defaultValue("python")
Review Comment:
Could we make this default OS-specific instead of using `python3`
unconditionally?
On Windows, standard Python installations and virtual environments reliably
provide `python.exe`, while `python3.exe` is not universally available.
I suggest using `python.exe` on Windows and `python3` elsewhere, and
applying the same default to `PYTHON_CLIENT_EXECUTABLE` for consistency:
private static final String DEFAULT_PYTHON_EXECUTABLE =
OperatingSystem.isWindows() ? "python.exe" : "python3";
##########
flink-python/docs/getting_started/installation.rst:
##########
@@ -28,35 +28,29 @@ Environment Requirements
.. code-block:: bash
- $ python --version
Review Comment:
This page explicitly states that PyFlink supports local development on
Windows, but the updated commands assume a POSIX environment. In particular,
`python3` is not universally available on Windows, and `command -v` and
`source` do not work in Command Prompt or PowerShell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
