Izeren commented on code in PR #28855:
URL: https://github.com/apache/flink/pull/28855#discussion_r3704106832
##########
flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java:
##########
@@ -661,9 +662,20 @@ public CompletableFuture<Acknowledge> submitTask(
TaskDeploymentDescriptor tdd, JobMasterId jobMasterId, Duration
timeout) {
final JobID jobId = tdd.getJobId();
- // todo: consider adding task info
- try (MdcCloseable ignored =
MdcUtils.withContext(MdcUtils.asContextData(jobId))) {
-
+ JobInformation jobInformation = null;
+ try {
+ jobInformation = tdd.getJobInformation();
+ } catch (IllegalStateException ignored) {
+ // Expected when job information is offloaded to blob storage and
not yet loaded.
Review Comment:
Will have a look
##########
flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java:
##########
@@ -572,6 +573,7 @@ private void runRecoveredJob(
initJobClientExpiredTime(recoveredJob);
final JobID jobId = recoveredJob.getJobID();
+ JobMdcRegistry.registerOrClear(jobId,
recoveredJob.getJobConfiguration());
try (MdcCloseable ignored =
MdcUtils.withContext(MdcUtils.asContextData(jobId))) {
Review Comment:
Will have a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
