twalthr commented on code in PR #28887:
URL: https://github.com/apache/flink/pull/28887#discussion_r3704378781
##########
flink-formats/flink-csv/src/test/java/org/apache/flink/formats/csv/CsvBulkWriterTest.java:
##########
@@ -44,7 +44,7 @@
import static org.assertj.core.api.Assertions.assertThat;
-public class CsvBulkWriterIT {
+class CsvBulkWriterTest {
Review Comment:
I see some `execute()` in this class.
```suggestion
class CsvBulkWriterITCase {
```
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/plan/nodes/exec/batch/SortAggregateBatchRestoreTest.java:
##########
@@ -24,7 +24,7 @@
import java.util.List;
/** Batch Compiled Plan tests for {@link BatchExecSortAggregate}. */
-class SortAggregateBatchRestoreTest extends BatchRestoreTestBase {
+public class SortAggregateBatchRestoreTest extends BatchRestoreTestBase {
Review Comment:
Why public now? While others can stay package private.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
