NestDream commented on PR #28360: URL: https://github.com/apache/flink/pull/28360#issuecomment-5171324887
Thanks for the review, @Samrat002. All three inline comments are addressed in 3bd3968: - Merged the two upload-failure tests into a single parameterized test, `uploadPartFailureIsReclaimedByClose`, covering both call sites (`write()` and `closeForCommit()`). - Removed the explanatory comment above `deleteIfExists()` in `close()`. - Trimmed the test class and per-test javadocs so they describe the current contract instead of re-explaining the historical leak. I also rewrote the PR description to match what the patch fixes today: with the original commit-path leak fixed on master by FLINK-39110, this PR makes the temp-file cleanup idempotent and pins that contract with tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
