rkhachatryan commented on code in PR #28861: URL: https://github.com/apache/flink/pull/28861#discussion_r3707755140
########## AGENTS.md: ########## @@ -305,6 +305,15 @@ This section maps common types of Flink changes to the modules they touch and th - You must be able to explain the design, code, and tests, debug them, and respond to review feedback substantively - Reviewer-ready quality bar: the author owns PR quality. PRs that look AI-generated without author refinement (walls of unreviewed prose, scaffolding without behaviour, tests that do not exercise the change, padded commit messages) will be closed without review +## Code Review Guidelines + +When reviewing a PR or diff against this repo: + +- Look for opportunities to simplify the code, scoped to the diff itself (not pre-existing code outside the change). +- Flag comments that are obvious (restate what the code already says) or overly verbose. +- In test code, look for potential flakiness — e.g. `Thread.sleep` used outside a retry/poll loop, or similar timing-dependent, non-deterministic patterns. Review Comment: Good idea! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
