lihaosky commented on code in PR #28789:
URL: https://github.com/apache/flink/pull/28789#discussion_r3707801931
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/CreateConnectionITCase.java:
##########
@@ -73,6 +73,29 @@ void
testCreatePermanentConnectionRejectedWithoutSecretStore() {
.hasMessageContaining("WritableSecretStore must be
configured");
}
+ @Test
+ void testDropTemporaryConnection() {
+ tEnv().executeSql("CREATE TEMPORARY CONNECTION my_conn WITH ('k' =
'v')");
+
+ tEnv().executeSql("DROP TEMPORARY CONNECTION my_conn");
+
+
assertThat(catalogManager().getConnection(connectionIdentifier("my_conn"))).isEmpty();
+ }
+
+ @Test
+ void testDropTemporaryConnectionIfExists() {
+ tEnv().executeSql("DROP TEMPORARY CONNECTION IF EXISTS my_conn");
Review Comment:
Also `drop system connection` should be rejected
##########
flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/operations/ddl/DropConnectionOperation.java:
##########
@@ -0,0 +1,89 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.operations.ddl;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.api.internal.TableResultImpl;
+import org.apache.flink.table.api.internal.TableResultInternal;
+import org.apache.flink.table.catalog.ObjectIdentifier;
+import org.apache.flink.table.operations.Operation;
+import org.apache.flink.table.operations.OperationUtils;
+
+import java.util.Collections;
+import java.util.LinkedHashMap;
+import java.util.Map;
+
+/** Operation to describe a DROP CONNECTION statement. */
+@Internal
+public class DropConnectionOperation implements DropOperation {
+
+ private final ObjectIdentifier connectionIdentifier;
+ private final boolean ifExists;
+ private final boolean isTemporary;
+ private final boolean isSystemConnection;
+
+ public DropConnectionOperation(
+ ObjectIdentifier connectionIdentifier,
+ boolean ifExists,
+ boolean isTemporary,
+ boolean isSystemConnection) {
+ this.connectionIdentifier = connectionIdentifier;
+ this.ifExists = ifExists;
+ this.isTemporary = isTemporary;
+ this.isSystemConnection = isSystemConnection;
+ }
+
+ public ObjectIdentifier getConnectionIdentifier() {
+ return connectionIdentifier;
+ }
+
+ public boolean isIfExists() {
+ return ifExists;
+ }
+
+ public boolean isTemporary() {
+ return isTemporary;
+ }
+
+ public boolean isSystemConnection() {
+ return isSystemConnection;
+ }
+
+ @Override
+ public String asSummaryString() {
+ Map<String, Object> params = new LinkedHashMap<>();
+ params.put("identifier", connectionIdentifier);
+ params.put("ifExists", ifExists);
+ params.put("isTemporary", isTemporary);
+ params.put("isSystemConnection", isSystemConnection);
+
+ return OperationUtils.formatWithChildren(
+ "DROP CONNECTION", params, Collections.emptyList(),
Operation::asSummaryString);
+ }
+
+ @Override
+ public TableResultInternal execute(Context ctx) {
+ if (isTemporary) {
+
ctx.getCatalogManager().dropTemporaryConnection(connectionIdentifier, ifExists);
+ } else {
+ ctx.getCatalogManager().dropConnection(connectionIdentifier,
ifExists);
+ }
Review Comment:
Please add a todo with flink ticket to handle `drop temporary system
connection`
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/CreateConnectionITCase.java:
##########
@@ -73,6 +73,29 @@ void
testCreatePermanentConnectionRejectedWithoutSecretStore() {
.hasMessageContaining("WritableSecretStore must be
configured");
}
+ @Test
+ void testDropTemporaryConnection() {
+ tEnv().executeSql("CREATE TEMPORARY CONNECTION my_conn WITH ('k' =
'v')");
+
+ tEnv().executeSql("DROP TEMPORARY CONNECTION my_conn");
+
+
assertThat(catalogManager().getConnection(connectionIdentifier("my_conn"))).isEmpty();
+ }
+
+ @Test
+ void testDropTemporaryConnectionIfExists() {
+ tEnv().executeSql("DROP TEMPORARY CONNECTION IF EXISTS my_conn");
+
+
assertThat(catalogManager().getConnection(connectionIdentifier("my_conn"))).isEmpty();
+ }
+
+ @Test
+ void testDropMissingTemporaryConnectionRejected() {
+ assertThatThrownBy(() -> tEnv().executeSql("DROP TEMPORARY CONNECTION
my_conn"))
+ .isInstanceOf(ValidationException.class)
+ .hasMessageContaining("Temporary connection with identifier");
Review Comment:
Can you have more messages about the connection doesn't exist?
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/runtime/batch/sql/CreateConnectionITCase.java:
##########
@@ -73,6 +73,29 @@ void
testCreatePermanentConnectionRejectedWithoutSecretStore() {
.hasMessageContaining("WritableSecretStore must be
configured");
}
+ @Test
+ void testDropTemporaryConnection() {
+ tEnv().executeSql("CREATE TEMPORARY CONNECTION my_conn WITH ('k' =
'v')");
+
+ tEnv().executeSql("DROP TEMPORARY CONNECTION my_conn");
Review Comment:
There's no test for `drop connection`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
