rosemarYuan commented on PR #954: URL: https://github.com/apache/flink-agents/pull/954#issuecomment-5176176128
> Hi, @rosemarYuan. Thanks for the PR. Overall, it looks good to me. I have just one minor suggestion. Thanks for the suggestion! I applied it, but it turns out this change breaks the cross-language E2E tests — the CI failure is NoClassDefFoundError: org/slf4j/LoggerFactory.The reason is that in cross-language tests, Python spawns a Java subprocess running the Plan tool directly (not inside a Flink cluster). When slf4j-api is marked as provided, it's excluded from the Plan module's transitive dependencies, so the subprocess's classpath doesn't include it. Unlike IT tests (where Flink's lib/ provides SLF4J) or unit tests (where Maven automatically adds provided deps to the test classpath), the cross-language test environment has no external provider for this dependency.This is why I originally kept slf4j-api as a compile-scope dependency in Plan — standalone Plan tool usage (including being invoked from Python) requires it to be bundled. The Dist shade plugin already excludes slf4j-api from the fat jar, so there's no duplication risk in the Flink deployment scenario. I'll revert this commit to fix the CI. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
