gustavodemorais opened a new pull request, #28918: URL: https://github.com/apache/flink/pull/28918
## What is the purpose of the change An append-only query into a sink with a primary key and no ON CONFLICT clause currently enables the sink upsert materializer, adding a SinkUpsertMaterializer and a keyed shuffle the pipeline did not have before FLIP-558. This keeps those queries unmaterialized, since an absent clause selects DEDUPLICATE and insert-only input has nothing to deduplicate. It is only reachable with table.exec.sink.require-on-conflict set to false, which otherwise rejects the missing clause. ## Brief change log - Short-circuit the AUTO upsert-materialize branch for insert-only input when no ON CONFLICT clause is specified. - Move the short-circuit after the require-on-conflict validation so a missing clause is still reported. - Extract validateOnConflictSpecifiedIfRequired out of analyzeUpsertMaterializeStrategy. ## Verifying this change - TableSinkTest ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes - a re-planned job drops SinkUpsertMaterializer and its keyed state, so the topology changes on restore; compiled plans are unaffected because requireUpsertMaterialize is persisted - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes (please specify the tool below) 2.1.220 (Claude Code) with Opus 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
