Savonitar commented on code in PR #28857:
URL: https://github.com/apache/flink/pull/28857#discussion_r3719465851
##########
flink-runtime/src/main/java/org/apache/flink/runtime/source/coordinator/SourceCoordinatorContext.java:
##########
@@ -170,7 +170,8 @@ public SourceCoordinatorContext(
new ThrowableCatchingRunnable(
this::handleUncaughtExceptionFromAsyncCall, runnable));
- this.notifier = new ExecutorNotifier(workerExecutor,
errorHandlingCoordinatorExecutor);
+ // Deliberately this.workerExecutor (job-scoped), not the raw
constructor parameter.
Review Comment:
> I assume, the reason is that wrapping from above:
MdcUtils.scopeToJob(jobID, workerExecutor);
Yes, correct. Updated comment to:
```
// Must be the field, not the constructor parameter: the field is the
scopeToJob-wrapped
// executor, so the callables ExecutorNotifier schedules on it, one-shot and
periodic alike,
// log with the job id rather than an empty MDC.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
