wenjin272 commented on code in PR #967:
URL: https://github.com/apache/flink-agents/pull/967#discussion_r3720026641
##########
e2e-test/pom.xml:
##########
@@ -31,7 +31,7 @@ under the License.
<properties>
<!-- The default E2E runtime is Flink 2.3. Profiles override this when
needed. -->
- <flink.log4j2.version>2.25.3</flink.log4j2.version>
+ <flink.log4j2.version>2.25.4</flink.log4j2.version>
Review Comment:
Could we keep this at `2.25.3`? `flink.log4j2.version` is intentionally
aligned with the Log4j version provided by the selected Flink runtime, rather
than being a general dependency version. Flink 2.3.0 provides `2.25.3` (while
the older Flink profiles override it with `2.24.3`). Updating this to `2.25.4`
makes the E2E JVM test a different logging classpath from the actual Flink
distribution, defeating the alignment introduced in #954 and potentially hiding
linkage issues. This property should only move when the corresponding Flink
version does.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
