joeyutong commented on code in PR #944: URL: https://github.com/apache/flink-agents/pull/944#discussion_r3726939847
########## runtime/src/main/java/org/apache/flink/agents/runtime/operator/CloseableUtils.java: ########## @@ -0,0 +1,32 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.flink.agents.runtime.operator; + +import org.apache.flink.util.LambdaUtil; + +import java.util.Arrays; + +final class CloseableUtils { + + private CloseableUtils() {} + + static void closeAll(AutoCloseable... closeables) throws Exception { Review Comment: You're right. I had previously worried that the available utilities did not quite match the required aggregation semantics, and I was probably over-cautious when extracting the local helper. has exactly the behavior needed here. I replaced both local-helper call sites and the hand-rolled path with it, removed , and also used it for the new aggregation in 56795e15. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
