gustavodemorais opened a new pull request, #28933: URL: https://github.com/apache/flink/pull/28933
## What is the purpose of the change WatermarkCompactingSinkMaterializer removed buffer entries while iterating and read their values afterwards. The value of a Map.Entry is undefined once the entry has been removed, and RocksDBMapEntry returns null for it, so consolidation on restore only works because the heap backend keeps removed values readable. ## Brief change log - Consume all buffered values in consolidateBufferToMinValue before mutating the buffer, and drop it with a single clear() - Iterate values() instead of entries() in the ordered branch ## Verifying this change - WatermarkCompactingSinkMaterializerTest ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): no - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no - The serializers: no - The runtime per-record code paths (performance sensitive): no - consolidation runs at most once per key per restore - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no - The S3 file system connector: no ## Documentation - Does this pull request introduce a new feature? no - If yes, how is the feature documented? not applicable --- ##### Was generative AI tooling used to co-author this PR? - [x] Yes (please specify the tool below) 2.1.220 (Claude Code) with Opus 5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
