Zhuoxi2000 commented on PR #945: URL: https://github.com/apache/flink-agents/pull/945#issuecomment-5208139060
Addressed all five comments (plus a merge of main to pick up #962 — the `vllm` alias now has `resolveClazz` coverage in both `AliasesTest` and `test_aliases.py`, following that PR's pattern): - Python treats whitespace-only values as absent (strip-based), with `" "` tests mirroring the Java suite - `withVLLMDefaults` is package-visible and the suggested assertion is adopted verbatim - The env-var pre-emption is documented as deliberate, in the docstring and the Python parameter table - The FAQ support matrix gained the vLLM row - The Java table types now say `int`, matching the other tables -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
