1996fanrui opened a new pull request, #28936:
URL: https://github.com/apache/flink/pull/28936
## What is the purpose of the change
When the delivery of a filtered buffer fails,
`FilteringHandler#recoverWithFiltering` recycles
a buffer that the input channel already owns, corrupting its reference count.
## Brief change log
- The compensating loop in the catch block starts at `i + 1`:
`onRecoveredStateBuffer()` takes
over the buffer at index `i` before anything can fail.
## Verifying this change
This change added tests and can be verified as follows:
- Added
`InputChannelRecoveredStateHandlerTest#testFilteredBuffersRecycledOnceWhenDeliveryFails`,
which fails the delivery of the first filtered buffer and asserts that
only the undelivered
buffers are recycled.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- The public API, i.e., is any changed class annotated with
`@Public(Evolving)`: no
- The serializers: no
- The runtime per-record code paths (performance sensitive): no
- Anything that affects deployment or recovery: JobManager (and its
components), Checkpointing, Kubernetes/Yarn, ZooKeeper: yes, the error handling
of channel state recovery
- The S3 file system connector: no
## Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
