wenjin272 commented on code in PR #979: URL: https://github.com/apache/flink-agents/pull/979#discussion_r3740239688
########## tools/build.sh: ########## @@ -101,7 +101,7 @@ if $build_python; then # build python cd python rm -rf dist/ # Clean old build artifacts before building - pip install uv==0.11.0 + python3 -m pip install uv==0.11.0 Review Comment: Using `python3 -m pip` here does not fully remove the `PATH` dependency. If Python’s scripts directory is not on `PATH` (a common reason why bare `pip` is unavailable), this installation succeeds but the next bare `uv` invocation fails with `command not found`. The same issue applies to `ruff` in `lint.sh` and `pytest` in `ut.sh`. Could we invoke all installed tools through the same interpreter (`python3 -m uv`, `python3 -m ruff`, and `python3 -m pytest`), or explicitly add that scripts directory to `PATH`? I reproduced this with a temporary `PYTHONUSERBASE`: `python3 -m pip` and `python3 -m uv` worked, while bare `uv` exited with 127. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
