Timm0 commented on code in PR #28886:
URL: https://github.com/apache/flink/pull/28886#discussion_r3735820762
##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/api/QueryOperationSqlSerializationTest.java:
##########
@@ -138,6 +124,46 @@ void testSqlAsJobNameForQueryOperation(TableTestProgram
program) {
assertThat(streamGraph.getJobName()).isEqualTo(sqlStep.sql);
}
+ @Test
+ void testProctimeWindowGeneratedSqlPlans() {
Review Comment:
Tried this, but a `proctime` window can't be covered by
`QueryOperationSqlSemanticTest`. A proctime window only fires from a
processing-time timer, and since `CommonSemanticTestBase` doesn't set
terminating=false on the source (unlike `RestoreTestBase` for example) the
bounded source ends the job before the timer fires and the sink stays empty.
I kept the test in `QueryOperationSqlSerializationTest` for now and added a
comment to the test program. Let me know if you want me to do this differently.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
