weiqingy commented on PR #28952: URL: https://github.com/apache/flink/pull/28952#issuecomment-5248930932
Copilot's four comments are resolved in 7912a13e609 and ad2fdc1ea6d: the per-side fired-state read is now gated on that side actually being outer, and the `EmitAwareCollector` class javadoc no longer carries a dead Scala-style link or describes a row kind the code does not use. Gating that read turned up a gap: the suite could not tell the correct gate from an equality test that would break FULL joins, so `testRowTimeFullOuterEarlyFireOneMatches` now drives the right-side retraction as well. cc @RocMarshal, this one is ready for review when you have time. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
