hulincup commented on code in PR #28931:
URL: https://github.com/apache/flink/pull/28931#discussion_r3755725017


##########
flink-table/flink-table-planner/src/test/java/org/apache/flink/table/planner/functions/StringFunctionsITCase.java:
##########
@@ -182,6 +186,26 @@ private Stream<TestSetSpec> eltTestCases() {
                                 DataTypes.VARCHAR(5))
                         .testResult(
                                 lit(2).elt("a", "b"), "ELT(2, 'a', 'b')", "b", 
DataTypes.CHAR(1))
+                        .testResult(
+                                lit(2).cast(DataTypes.TINYINT()).elt("scala", 
"java"),
+                                "ELT(CAST(2 AS TINYINT), 'scala', 'java')",
+                                "java",
+                                DataTypes.VARCHAR(5))
+                        .testResult(
+                                $("f4").elt("scala", "java"),
+                                "ELT(f4, 'scala', 'java')",
+                                "java",
+                                DataTypes.VARCHAR(5))
+                        .testResult(

Review Comment:
   Added in a4e350f — `$("f4").elt($("f3"), $("f2"))`: f4 is a non-literal 
TINYINT index (the codegen path), f2 holds null BYTES data at the selected 
position, so the result is null.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to