kaiwangleo opened a new pull request, #996:
URL: https://github.com/apache/flink-agents/pull/996

   Linked issue: N/A (hotfix)
   
   ### Purpose of change
   
   Make `tools/check-license.sh` report the actual cause when Apache RAT cannot 
be downloaded or validated. The script now:
   
   - uses the JDK `jar` tool when available and falls back to `unzip`;
   - reports missing download and validation tools explicitly;
   - preserves HTTP errors from curl with `--fail --show-error --location`;
   - removes partial downloads after failures;
   - validates cached RAT JARs before using them;
   - distinguishes an invalid JAR from a missing validation dependency.
   
   ### Tests
   
   - Added `tools/test/unit/check_license.bats` covering missing validation 
tools, invalid cached JARs, valid cached JARs, download failures, partial-file 
cleanup, curl flags, and successful validation.
   - `bash -n tools/check-license.sh`
   - `bash tools/test/.bats-cache/bats-core/bin/bats 
tools/test/unit/check_license.bats` (5 tests passed)
   - `git diff --check`
   - `bash tools/check-license.sh` did not complete within 60 seconds on the 
Windows-mounted workspace; no failure result was produced.
   
   ### API
   
   No public API changes.
   
   ### Documentation
   
   - [ ] `doc-needed`
   - [x] `doc-not-needed`
   - [ ] `doc-included`
   
   ### Was this patch authored or co-authored using generative AI tooling?
   
   - [x] Yes
   - [ ] No
   
   Generated-by: OpenAI Codex Desktop 26.803.41515 (GPT-5.6 Sol)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to