nishita-09 commented on code in PR #1000:
URL:
https://github.com/apache/flink-kubernetes-operator/pull/1000#discussion_r3757638090
##########
flink-kubernetes-operator/src/main/java/org/apache/flink/kubernetes/operator/reconciler/deployment/AbstractFlinkResourceReconciler.java:
##########
@@ -363,7 +363,12 @@ private boolean scale(FlinkResourceContext<CR> ctx,
Configuration deployConfig)
var scaled = ctx.getFlinkService().scale(ctx, deployConfig);
if (scaled) {
- ReconciliationUtils.updateStatusForDeployedSpec(ctx.getResource(),
deployConfig, clock);
Review Comment:
Yes @gyfora I was relying on upstream callers, or previous actions like
cancelJob or other terminating function to invalidate it but its good to have
it in deploy as well to ensure we don't face any inconsistency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
