weiqingy commented on code in PR #995: URL: https://github.com/apache/flink-agents/pull/995#discussion_r3763577593
########## tools/test/integration/build_help.bats: ########## @@ -0,0 +1,47 @@ +#!/usr/bin/env bats + +################################################################################ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. +################################################################################ + +BUILD_SCRIPT="${BATS_TEST_DIRNAME}/../../build.sh" + +@test "build --help prints usage and exits 0" { + run bash "$BUILD_SCRIPT" --help + + [ "$status" -eq 0 ] + [[ "$output" == *"Build Flink Agents Java and Python artifacts"* ]] + [[ "$output" == *"Usage:"* ]] + [[ "$output" == *"--java"* ]] + [[ "$output" == *"--python"* ]] +} + +@test "build -h prints usage and exits 0" { + run bash "$BUILD_SCRIPT" -h + + [ "$status" -eq 0 ] + [[ "$output" == *"Usage:"* ]] +} + +@test "build rejects an unknown option with usage" { + run bash "$BUILD_SCRIPT" --no-such-option + + [ "$status" -ne 0 ] Review Comment: nit: `-ne 0` passes whether the script is broken or fixed. On `main` this path exits 127, and with your fix it exits 1, so both satisfy the check. I tried changing the `*)` branch to `exit 2` locally and all three tests still passed, so nothing here locks in the exit code your fix actually produces. The test does still go red against `main`, just through the `Usage:` check below it, so it is doing its job. Would `[ "$status" -eq 1 ]` be worth using instead? That would say an unknown option is a usage error rather than a crash. Curious whether you left it loose on purpose. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
