pltbkd commented on code in PR #938: URL: https://github.com/apache/flink-agents/pull/938#discussion_r3765329579
########## api/src/main/java/org/apache/flink/agents/api/subagent/SubagentFuture.java: ########## @@ -0,0 +1,75 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.agents.api.subagent; + +/** + * Driving handle for one sub-agent invocation, carrying the {@code (sessionId, callId)} identity + * that keys the invocation's durable state. + * + * <p>The handle is a driver of the invocation's lifecycle, not a passive view: resolving it issues + * the request when it has not been issued yet, and its wait releases the mailbox so other work can + * proceed in between. Its heap state does not survive a failover; the identity is the only basis + * for rebuilding it through replay. + * + * <p>Returned by {@link Subagent#submit}. The invocation is always deferred: the request is issued Review Comment: Yes, that paragraph describes the deferred mode. It predates the async base and wasn't updated when that landed, I'll align the doc to the final state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
