gustavodemorais commented on code in PR #28850:
URL: https://github.com/apache/flink/pull/28850#discussion_r3765640722
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/functions/BuiltInFunctionDefinitions.java:
##########
@@ -3104,6 +3105,25 @@ ANY, and(logical(LogicalTypeRoot.BOOLEAN), LITERAL)
.runtimeProvided()
.build();
+ public static final BuiltInFunctionDefinition JSON_TYPE =
+ BuiltInFunctionDefinition.newBuilder()
+ .name("JSON_TYPE")
+ .kind(SCALAR)
+ .inputTypeStrategy(
+ jsonWithOptionalPath(
Review Comment:
Let's call it `plainJsonPath` and reuse for json length
##########
flink-table/flink-table-planner/src/main/java/org/apache/flink/table/planner/codegen/JsonCodeGenUtils.java:
##########
@@ -0,0 +1,119 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.planner.codegen;
+
+import org.apache.flink.table.planner.codegen.calls.BuiltInMethods;
+import org.apache.flink.table.runtime.functions.SqlJsonUtils;
+import org.apache.flink.table.types.logical.LogicalType;
+
+import scala.Option;
+import scala.Tuple2;
+import scala.collection.Seq;
+
+/** Utilities for the code generation of JSON functions. */
+public final class JsonCodeGenUtils {
+
+ private JsonCodeGenUtils() {}
+
+ /**
+ * Generates {@code JSON_TYPE(jsonValue)} or {@code JSON_TYPE(jsonValue,
path)}.
+ *
+ * <p>The parsed context is shared with the other JSON functions over the
same input, so the
+ * input is parsed only once per record.
+ */
+ public static GeneratedExpression generateJsonType(
+ CodeGeneratorContext ctx, LogicalType returnType,
Seq<GeneratedExpression> operands) {
+ boolean hasPath = operands.length() == 2;
+ return GenerateUtils.generateCallWithStmtIfArgsNotNull(
+ ctx,
+ returnType,
+ operands,
+ true,
+ false,
+ argTerms -> {
+ ParsedJson parsed = getOrCreateParsedJson(ctx,
argTerms.head() + ".toString()");
Review Comment:
getOrCreateParsedJson is now duplicated almost verbatim in JsonLengthCallGen
- could we extract it so both share it? Your new version is the better one and
we could go with it
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/types/inference/strategies/JsonPathInputTypeStrategy.java:
##########
@@ -0,0 +1,84 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.flink.table.types.inference.strategies;
+
+import org.apache.flink.annotation.Internal;
+import org.apache.flink.table.functions.FunctionDefinition;
+import org.apache.flink.table.types.DataType;
+import org.apache.flink.table.types.inference.ArgumentCount;
+import org.apache.flink.table.types.inference.CallContext;
+import org.apache.flink.table.types.inference.InputTypeStrategy;
+import org.apache.flink.table.types.inference.Signature;
+
+import java.util.List;
+import java.util.Optional;
+import java.util.regex.Pattern;
+
+/**
+ * Strategy for a JSON function whose optional second argument is a path
literal. Rejects the {@code
+ * lax}/{@code strict} path mode prefix at planning time and delegates
everything else to {@code
+ * signatures}.
+ */
+@Internal
+public final class JsonPathInputTypeStrategy implements InputTypeStrategy {
+
+ private static final int ARG_PATH = 1;
+
+ private static final Pattern PATH_MODE_PREFIX =
Review Comment:
Could you point JSON_LENGTH at the new strategy too? I see it's still
throwing TableRuntimeException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
