dalelane commented on code in PR #28740:
URL: https://github.com/apache/flink/pull/28740#discussion_r3790191059
##########
docs/static/generated/rest_v4_sql_gateway.yml:
##########
@@ -516,6 +516,7 @@ components:
- DESCRIPTOR
- VARIANT
- BITMAP
+ - GEOGRAPHY
Review Comment:
This would end up advertising GEOGRAPHY to REST clients that isn't supported
by the gateway yet.
I know your PR description says that follow-up changes are coming, but do
you think it's worth making updates to `LogicalTypeJsonSerializer.java` and
`LogicalTypeJsonDeserializer.java` in `flink-table/flink-sql-gateway` in this
PR?
It probably just needs a new case in the switch statements in
serializeInternal and deserializeInternal
##########
flink-table/flink-table-common/src/main/java/org/apache/flink/table/api/DataTypes.java:
##########
@@ -1075,6 +1076,15 @@ public static DataType BITMAP() {
return new AtomicDataType(new BitmapType());
}
+ /**
+ * Data type of geography data.
+ *
+ * @see GeographyType
+ */
+ public static DataType GEOGRAPHY() {
Review Comment:
do you think we need a new datatype converter for geography in
https://github.com/akvelon/flink/blob/fccf3126db72d8fbbb3829f81c4f123d1f005df4/flink-table/flink-table-runtime/src/main/java/org/apache/flink/table/data/util/DataFormatConverters.java#L115-L165
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
