dalelane commented on code in PR #293:
URL:
https://github.com/apache/flink-connector-kafka/pull/293#discussion_r3792681091
##########
flink-connector-kafka/src/test/java/org/apache/flink/connector/kafka/source/reader/KafkaSourceReaderTest.java:
##########
@@ -266,6 +273,340 @@ void testOffsetCommitOnCheckpointComplete() throws
Exception {
}
}
+ @Test
+ void testCommittedOffsetConvergesWithLogEndOffsetForTransactionalTopic()
throws Throwable {
Review Comment:
thanks for the review, @Efrat19
That does reduce the copy/pasted logic duplication across my tests - applied
in ce28b75b7f7a9b288bb1b31ffd975fae0255be27
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
