NestDream commented on PR #28360: URL: https://github.com/apache/flink/pull/28360#issuecomment-5309747349
Thanks for the review, @gaborgsomogyi! Both comments are addressed: 1. The two listing helpers are collapsed into a single `tempFiles(dir)`, used for the assertions both before and after close(). 2. Each of the three converted cleanup sites now has its own test that fails with `NoSuchFileException` on the unfixed code, covering closeForCommit(), uploadCurrentPart() and close() respectively. Details in the inline replies. I've squashed them into one single commit and rebased on main branch. Happy to adjust further if you would prefer anything structured differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
