weiqingy opened a new pull request, #1022: URL: https://github.com/apache/flink-agents/pull/1022
Linked issue: #894 ### Purpose of change `code_review.md`'s Change-Type Review Guides table had one row left reading `planned`. A reviewer facing a change to what the project ships fell back to the general passes, which ask the right question without saying what breaks in this area. This adds `review-guides/dist-dependency.md` and links that row, completing the set of four guides. The guide is organised around the failures the build does not report, rather than around the three sub-areas the table's Focus cell names, because the mechanisms cut across them. What it covers: - A module missing from `dist/pom.xml` can compile, test, and release green while shipping none of its classes. The shipped set is a hand-written list of dependencies rather than anything derived from the reactor. - Nothing in the build validates a NOTICE, so a transitive addition can change what is bundled without appearing in the diff and without any check noticing. - Nothing is relocated, so a bundled dependency's version can be settled by Maven mediation rather than declared, and the version one integration pulls in becomes the version the others get. - Moving a dependency into or out of `provided` or `test` changes what ships, while moving between `compile` and `runtime` does not. - An exclude inside a shade filter whose artifact pattern matches everything applies to every artifact being shaded. - The licence check keys on the Apache License URL, so a header that keeps that URL passes with prose lines dropped or altered. The `dist registration` sub-area has no example row. No reviewer has raised a missing dist registration on any PR in this repository, merged or open, across the full inline-comment history. Rather than stretch a citation, that sub-area is covered by a checklist bullet and cited to nothing. ### Tests No code changes, so verification was of the guide's claims and its published commands. Every command in the Validation block was run as written, at two different substitutions of the `<version>` placeholder. `./tools/check-license.sh` exits 0, and the new file needs no licence header because `tools/.rat-excludes` already covers `review-guides/*` — confirmed with a control file rather than by reading the glob. The factual claims were verified against built artifacts rather than against the poms. The scope claim was measured across 177 artifacts on a built fat jar: compile and runtime dependencies are all present, provided and test dependencies all absent. The licence-header behaviour was established by running Apache RAT against deliberately degraded headers. The relative link was resolved by hand, since no markdown link checker runs anywhere in the repository. ### API No. Documentation only. ### Documentation - [ ] `doc-needed` - [ ] `doc-not-needed` - [x] `doc-included` ### Was this patch authored or co-authored using generative AI tooling? - [x] Yes - [ ] No Generated-by: Claude Code 2.1.233 (Claude Opus 5) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
