awesomesauce06 commented on code in PR #1005:
URL: https://github.com/apache/flink-agents/pull/1005#discussion_r3798469005
##########
python/flink_agents/runtime/skill/repository/_materialize.py:
##########
@@ -159,8 +167,31 @@ def download_to_tempfile(url: str, timeout: int = 90) ->
Path:
tmp_path = Path(tmp_path_str)
try:
with urlopen(req, timeout=timeout) as resp, tmp_path.open("wb") as out:
Review Comment:
agreed here - added handler that rejects protocol changes before the target
request is sent, including redirects to HTTP or FTP. also replaced the stubbed
test with a real `HTTPServer` test.
##########
python/flink_agents/runtime/skill/repository/_materialize.py:
##########
@@ -159,8 +167,31 @@ def download_to_tempfile(url: str, timeout: int = 90) ->
Path:
tmp_path = Path(tmp_path_str)
try:
with urlopen(req, timeout=timeout) as resp, tmp_path.open("wb") as out:
Review Comment:
agreed here - added handler that rejects protocol changes before the target
request is sent, including redirects to HTTP or FTP. also replaced the stubbed
test with a real `HTTPServer` test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
