haruki-830 commented on code in PR #4503:
URL: https://github.com/apache/flink-cdc/pull/4503#discussion_r3802333377


##########
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/JaninoCompiler.java:
##########


Review Comment:
   Thanks for catching this! 
   I have propagated `context.decimalPrecisionMode` to all four affected 
`deduceSubExpressionType(...)` calls in `JaninoCompiler`. Also added `UP_TO_38` 
coverage for DECIMAL arithmetic nested inside `IFNULL`, `NULLIF`, and 
collection constructors. The tests pass locally with both Flink 1.20 and Flink 
2.x.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to