lvyanquan commented on PR #4509:
URL: https://github.com/apache/flink-cdc/pull/4509#issuecomment-5337186038

   Could we first clarify the unit and semantics of `currentBinlogPositionLag`?
   
   Currently, the same gauge represents different quantities:
   
    - GTID sets differ: the value is an estimated transaction count.
    - GTID sets are equal or GTID is disabled: the value is a byte-position 
difference.
    - Binlog files differ: the value is a synthetic estimate based on 
`fileSequenceDiff * 1_000_000`.
   
   As a result, the metric may switch units at runtime and cannot be 
interpreted consistently or
   used with a stable alert threshold. The cross-file value also has no 
physical unit.
   
   I think we should define whether this metric represents transaction count, 
byte lag, or an abstract position distance before finalizing the calculation. 
If both transaction and byte lag are useful, exposing separate metrics may be 
clearer.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to