Zhuoxi2000 commented on PR #290: URL: https://github.com/apache/flink-connector-kafka/pull/290#issuecomment-5344189390
The architecture test caught one issue on my side: the new `@VisibleForTesting` annotation on `createConsumer` trips the freezing ArchUnit rule, since it only allows the class’s existing violations. I removed the annotation and kept the seam package-private, with the javadoc explaining why it exists. `ProductionCodeArchitectureTest` and the module tests pass locally now. @AHeise could you approve the CI run once more when you get a chance? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
