akalash commented on code in PR #28999:
URL: https://github.com/apache/flink/pull/28999#discussion_r3822567937
##########
flink-runtime/src/main/java/org/apache/flink/runtime/scheduler/adaptive/AdaptiveScheduler.java:
##########
@@ -1269,16 +1285,21 @@ public ArchivedExecutionGraph getArchivedExecutionGraph(
}
@Override
- public void goToWaitingForResources(@Nullable ExecutionGraph
previousExecutionGraph) {
+ public void goToWaitingForResources(
+ @Nullable ExecutionGraph previousExecutionGraph,
+ @Nullable VertexParallelism restartWithParallelism) {
declareDesiredResources();
transitionToState(
new WaitingForResources.Factory(
this,
LOG,
settings.getSubmissionResourceWaitTimeout(),
Review Comment:
Side note: It seems we use **Submission**ResourceWaitTimeout for all cases -
not only for submission. Perhaps we should follow-up on that with something
like:
```
previousExecutionGraph == null
? settings.getSubmissionResourceWaitTimeout()
: Duration.ofMillis(-1L)
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
