weiqingy commented on PR #992: URL: https://github.com/apache/flink-agents/pull/992#issuecomment-5382900467
@wenjin272 Thanks for the review. While working through your comments I ran into something separate and filed it as #1035. The bash 4+ guard in tools/test/run.sh only binds the launcher. bats-core's bats-exec-test re-execs through /usr/bin/env bash, so test bodies still run under /bin/bash 3.2 on macOS. Under 3.2 errexit does not apply to [[ ]], so a non-final [[ ]] assertion that is false reports ok and execution carries on. There are 42 such assertions across the bats suites, and 33 of them are in the file this PR added, so most of the cleanup is mine. I will send a separate PR for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
