weiqingy commented on PR #965: URL: https://github.com/apache/flink-agents/pull/965#issuecomment-5382911036
Thanks for the review. Confirmed, and it's both sides: Java defaults to `0.1` in `AnthropicChatModelSetup` and puts it in the parameter map unconditionally, Python does the same through `model_kwargs`. Neither gates on the model. Two things turned up while checking it. The affected set is wider than 4.7 and Mythos: sampling parameters are also rejected on Opus 4.8 and 5, and on Sonnet 5 and Fable 5. And it isn't the same boundary as the prefill gate this PR adds, since prefill 400s on 4.6 and later but temperature on 4.7 and later. 4.6 accepts temperature while rejecting prefill, so it needs its own model list rather than reusing the one added here. I filed #1036 and opened #1037 with the fix. It drops the parameter on models that reject it rather than clamping it to the provider default, and logs once per model name so the drop isn't silent. `top_p` and `top_k` can reach the request through `additional_kwargs`, and the same models reject those too, but they're caller-supplied rather than defaulted by the integration so I left them out of that PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
