weiqingy commented on issue #1003:
URL: https://github.com/apache/flink-agents/issues/1003#issuecomment-5383724087

   One thing that came up reviewing #1005, adjacent to this but maybe not 
inside it.
   
   Neither runtime bounds how many bytes a URL skill source writes. The 
download streams straight to a temp file (`shutil.copyfileobj` in 
`_materialize.py`, `Files.copy` in `SkillMaterializer.java`), and extraction is 
unbounded too, so a small archive can expand well past its transfer size. 
Pinning doesn't help, since the digest is computed only after the file is 
already on disk, so a source that streams indefinitely fills TaskManager disk 
before any check runs.
   
   Same code path as this issue, different property though: resource exhaustion 
rather than transport or integrity. And since #1005 implements the bullets 
here, adding it now would widen the scope late.
   
   In scope for this one, or better tracked separately?
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to